-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed infinitely recursive health checks #3557
Fixed infinitely recursive health checks #3557
Conversation
d41a87f
to
091f880
Compare
637c418
to
6fcc890
Compare
6fcc890
to
a4b4639
Compare
@petyaslavova please review |
Hi @excitoon thank you for your contribution! We’ll review your change soon. |
Hi Petya, how's your weekend going? 🍻 |
@excitoon Tomorrow is the day for this PR review :) |
The change looks good to me. With it instead of the max recursion depth reached error, an "redis.exceptions.ConnectionError: max number of clients reached" is raised. |
@petyaslavova Not really, LGTM |
@petyaslavova Thanks alot! |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixed infinite recursion in health checks (once and for all).
Fixes #2866
Really fixes #2563