Skip to content

Link to API page for #:: is broken #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steinybot opened this issue Sep 16, 2021 · 5 comments
Closed

Link to API page for #:: is broken #2184

steinybot opened this issue Sep 16, 2021 · 5 comments

Comments

@steinybot
Copy link
Contributor

Not too sure if this is the correct place to report issues with the API docs but if you go to https://scala-lang.org/api/3.x/scala.html and then click on the link for #:: then that page is broken and it shows the index page instead.

@julienrf
Copy link
Contributor

julienrf commented Oct 4, 2021

Thank you @steinybot for the report! There might be a bug in scaladoc, maybe @BarkingBad can check?

@BarkingBad
Copy link
Contributor

It is very strange, the problem is apparently with # symbol, it fails also for inner object #:: in https://scala-lang.org/api/3.0.1/scala/collection/immutable/Stream$.html with Not found message. However, both these links work well at Nighly version https://dotty.epfl.ch/api/scala/collection/immutable/Stream$.html and https://dotty.epfl.ch/api/scala.html. The interesting thing is that these links look quite the same (different domain, but the same suffix), so they should behave the same. I think whether can it be a problem with server engine we use to serve docs.scala-lang, that fails for # in url.

@julienrf
Copy link
Contributor

My diagnostic is that there is something wrong in the rewrite rule that handles the URLs like /api/* in our HTTP server. Maybe @fsalvi can help us to fix this issue?

@fsalvi
Copy link
Contributor

fsalvi commented Nov 1, 2021

Sorry for the delay.
I tried to fix the problem. It looks better now. Let me know if you still see some problems...

@julienrf
Copy link
Contributor

julienrf commented Nov 1, 2021

Thank you Fabien, yes, the issue seems to be fixed now!

@julienrf julienrf closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants