Skip to content

Add the match expressions and switch/match content for Python part #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2021
Merged

Add the match expressions and switch/match content for Python part #2240

merged 1 commit into from
Dec 27, 2021
+18 −3

Conversation

byyue
Copy link
Contributor

@byyue byyue commented Nov 29, 2021

Close #2232.

  1. Structural pattern matching was added in Python 3.10, which can be reflected in the Scala for Python Developers chapter.
  2. Another subtle change is to replace "day" with "month" so that the code snippet can be more intuitive.

@galuszkak
Copy link

👍 I was actually wanting to contribute that change. Thanks @byyue!

@byyue
Copy link
Contributor Author

byyue commented Dec 15, 2021

👍 I was actually wanting to contribute that change. Thanks @byyue!

Thanks! Maybe you could help ping maintainers if you want as they probably overlooked this PR.

julienrf
julienrf approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@julienrf julienrf merged commit 4b46ca1 into scala:main Dec 27, 2021
@byyue byyue deleted the dev branch February 1, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scala 3 for python developers: switch/match/case
3 participants
@byyue @galuszkak @julienrf