Two fixes to handling of abstract types with cap bounds #22838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # compiler/src/dotty/tools/dotc/cc/Setup.scala
odersky
force-pushed
the
capability-bounds
branch
from
ff6f4b8 to
a94efa4
Compare
Simplifies previous too convoluted logic.
natsukagami
reviewed
Mar 27, 2025
| @@ -426,7 +426,8 @@ class TypeComparer(@constructorOnly initctx: Context) extends ConstraintHandling | |||
| if (tp1.prefix.isStable) return tryLiftedToThis1 | |||
| case _ => | |||
| if isCaptureVarComparison then | |||
| return subCaptures(tp1.captureSet, tp2.captureSet).isOK | |||
| return CCState.withCapAsRoot: | |||
There was a problem hiding this comment.
Should leave a comment to make sure we don't introduce unsoundness
| @@ -575,7 +576,8 @@ class TypeComparer(@constructorOnly initctx: Context) extends ConstraintHandling | |||
| && (isBottom(tp1) || GADTusage(tp2.symbol)) | |||
|
|
|||
| if isCaptureVarComparison then | |||
| return subCaptures(tp1.captureSet, tp2.captureSet).isOK | |||
| return CCState.withCapAsRoot: | |||
There was a problem hiding this comment.
Should leave a comment to make sure we don't introduce unsoundness
| @@ -1875,7 +1904,9 @@ class CheckCaptures extends Recheck, SymTransformer: | |||
| def traverse(t: Tree)(using Context) = t match | |||
| case tree: InferredTypeTree => | |||
| case tree: New => | |||
| case tree: TypeTree => checkAppliedTypesIn(tree.withType(tree.nuType)) | |||
| case tree: TypeTree => | |||
| CCState.withCapAsRoot: | |||
There was a problem hiding this comment.
Should leave a comment to make sure we don't introduce unsoundness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip implied cap.rd sets from Capability types in extends and bounds
I.e. We do not add an implicit cap.rd in
class C extends Capability
type T <: C
Don't map CapSet^ to CapSet^{fresh}. Assume
^is root in some comparisons with CapSet.