Use other tree for actual symbol of Assign #22869
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
cbdcdd5 to
ef97824
Compare
hamzaremmal
reviewed
Mar 28, 2025
Comment on lines
1539
to
1540
| |Also, assignment syntax can be used if there is a corresponding setter: | ||
| | ${hl("def")} ${name}${hl("_=(x: Int): Unit = _v = x")} |
There was a problem hiding this comment.
I wouldn't add this one here. The sugaring for setters is very very scope specific and fragile. It cannot be summarized into the assignment syntax can be used if there is a corresponding setter...
There was a problem hiding this comment.
I think some words are necessary for user who needs an explanation; I restricted it to class members.
hamzaremmal
reviewed
Mar 28, 2025
| @@ -1528,14 +1528,16 @@ class AmbiguousExtensionMethod(tree: untpd.Tree, expansion1: tpd.Tree, expansion | |||
|
|
|||
| class ReassignmentToVal(name: Name)(using Context) | |||
| extends TypeMsg(ReassignmentToValID) { | |||
| def msg(using Context) = i"""Reassignment to val $name""" | |||
| def msg(using Context) = i"""Reassignment to value $name""" | |||
There was a problem hiding this comment.
We could actually pass the symbol instead of the name and we would either get val, def,... depending on the actual symbol.
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
ef97824 to
76c6790
Compare
|
I started down the long tail of polishing words. Let the symbol say what it is, and restrict setter explanation to class-owned symbols. (Need to check class params.) |
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
76c6790 to
7785a12
Compare
som-snytt
force-pushed
the
issue/22671-assignment-error
branch
from
7785a12 to
21d48c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22671
Scala 2 says that the setter was not found.
For
+=it will add what error caused "convert to assignment" to fail. I added a test but not the addendum.The Scala 3 message text is tweaked. (A def is not a val, so just say "value".)
Scala 2 omits the name, since the caret points to the name, but supplying the name is useful if it is different from what is written.