Skip to content

[CLNP-6588] Add deps in unmount #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

[CLNP-6588] Add deps in unmount #1323

merged 2 commits into from
Apr 3, 2025

Conversation

chrisallo
Copy link
Collaborator

@chrisallo chrisallo commented Apr 2, 2025

[fix]: SendbirdProvider unmount not disconnects

Fixes CLNP-6588

Changelogs

  • Fixed a bug that the connection does not disconnect on unmount

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

@chrisallo chrisallo requested a review from git-babel April 2, 2025 07:34
@chrisallo chrisallo self-assigned this Apr 2, 2025
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 1568a1c
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/67edfee509de840008fe0c83
😎 Deploy Preview https://deploy-preview-1323--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@git-babel git-babel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisallo chrisallo merged commit 9e7575e into main Apr 3, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants