Skip to content

Commit 036e8c1

Browse files
committed
IOIO: update permission error text
1 parent 8079a76 commit 036e8c1

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

ioio/ioio/src/main/java/ioio/smallbasic/android/AccessoryPermissionCheck.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
import ioio.lib.spi.Log;
1717
import ioio.smallbasic.IOIOException;
18-
import ioio.smallbasic.IOUtil;
1918

2019
public class AccessoryPermissionCheck extends BroadcastReceiver {
2120
private static final String TAG = AccessoryPermissionCheck.class.getSimpleName();
@@ -26,8 +25,8 @@ public class AccessoryPermissionCheck extends BroadcastReceiver {
2625
public AccessoryPermissionCheck() {
2726
Log.d(TAG, "AccessoryPermissionCheck entered");
2827
UsbAccessory accessory = UsbUtil.getUsbAccessory();
29-
if (accessory == null) {
30-
throw new IOIOException("No usb accessory found.");
28+
if (accessory == null || !"IOIO".equals(accessory.getModel())) {
29+
throw new IOIOException("IOIO board not found.");
3130
}
3231

3332
UsbManager usbManager = UsbUtil.getUsbManager();
@@ -52,8 +51,10 @@ public AccessoryPermissionCheck() {
5251
public synchronized void onReceive(final Context context, Intent intent) {
5352
Log.d(TAG, "onReceive entered");
5453
if (ACTION_USB_PERMISSION.equals(intent.getAction())) {
55-
boolean permitted = UsbUtil.getUsbManager().hasPermission(UsbUtil.getUsbAccessory());
56-
final String message = "USB access " + (permitted ? "permitted" : "denied");
54+
UsbAccessory accessory = UsbUtil.getUsbAccessory();
55+
String version = accessory != null ? accessory.getVersion() : "";
56+
boolean permitted = UsbUtil.getUsbManager().hasPermission(accessory);
57+
final String message = "IOIO board [" + version + "] access " + (permitted ? "permitted" : "denied");
5758
final BroadcastReceiver receiver = this;
5859
new Handler(Looper.getMainLooper()).post(() -> {
5960
Toast.makeText(context, message, Toast.LENGTH_LONG).show();

ioio/ioio/src/main/java/ioio/smallbasic/android/UsbConnection.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ private void close() {
126126
inputStream = null;
127127
outputStream = null;
128128
fileDescriptor = null;
129-
} catch (java.io.IOException e) {
129+
} catch (IOException e) {
130130
IOUtil.setError("Failed to close file descriptor: " + e);
131131
Log.e(TAG, "Failed to close file descriptor.", e);
132132
}

0 commit comments

Comments
 (0)