feat: add C implementation for math/base/special/minmax

[Neerajpathak07]

Progresses #649,
Resolves #2106.

Description

What is the purpose of this pull request?

This pull request:

• adds C implementation for math/base/special/minmax

#include <stdint.h>

double min;
double max;

stdlib_base_minmax( 4.0, -5.0, &min, &max );

Related Issues

Does this pull request have any related issues?

This pull request:

• progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649
• resolves [RFC]: Add C implementation for @stdlib/math/base/special/minmax #2106

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/minmax	$253/253$ $+100.00\mathrm{\%}$	$17/17$ $+100.00\mathrm{\%}$	$3/3$ $+100.00\mathrm{\%}$	$253/253$ $+100.00\mathrm{\%}$

The above coverage report was generated for the changes in this PR.

[Neerajpathak07]

Have kept the addon logic as this for now and going through https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/napi to have an idea for a utility for void functions.
for this file I have refactored this code-block.

[Neerajpathak07]

Turns out we can convert it a very simplified fashion like:-

static napi_value addon( napi_env env, napi_callback_info info ) {
        STDLIB_NAPI_ARGV( env, info, argv, argc, 3 );
	STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 );
	STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 );
	STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, z, zlen, argv, 2 );
        
        double min;
	double max;
	stdlib_base_minmax( x, y, &min, &max );

	double *op = (double *)z;
	op[ 0 ] = min;
	op[ 1 ] = max;

	return NULL;
}

just searching for an utility that can accumulate void function.

[Neerajpathak07]

something similar was also done in rempio2

[gunjjoshi]

@Neerajpathak07 You can do something like this:

In addon.c, you can have:

#include "stdlib/math/base/special/minmax.h"
#include "stdlib/napi/export.h"
#include "stdlib/napi/argv.h"
#include "stdlib/napi/argv_double.h"
#include "stdlib/napi/argv_float64array.h"
#include <node_api.h>

/**
* Receives JavaScript callback invocation data.
*
* @param env    environment under which the function is invoked
* @param info   callback data
* @return       Node-API value
*/
static napi_value addon( napi_env env, napi_callback_info info ) {
    STDLIB_NAPI_ARGV( env, info, argv, argc, 3 );
    STDLIB_NAPI_ARGV_DOUBLE( env, x, argv, 0 );
    STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 1 );
    STDLIB_NAPI_ARGV_FLOAT64ARRAY( env, out, outlen, argv, 2 );
    stdlib_base_minmax( x, y, &out[ 0 ], &out[ 1 ] );
    return NULL;
}

STDLIB_NAPI_MODULE_EXPORT_FCN( addon )

And, for native.js:

function minmax( x, y ) {
	var out = new Float64Array( 2 );
	addon( x, y, out );
	return [ out[ 0 ], out[ 1 ] ];
}

[Neerajpathak07]

@gunjjoshi Bingo!!
I had drafted a similar logic earlier but was confused on how to go about the void function. But you just clarified it thank you soo much!!

[Neerajpathak07]

@gunjjoshi LMK your opinion on this!!

[Neerajpathak07]

Not sure though why only C examples CI tests are failing for #include <node_api.h> and not for any other files.