Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add constants/float32/max-safe-lucas #6374

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 25, 2025

Progresses #649 .

Description

What is the purpose of this pull request?

This pull request:

  • adds constants/float32/max-safe-lucas .

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@hrshya hrshya changed the title feat: add constants/float32/max-safe-lucas feat: add constants/float32/max-safe-lucas Mar 25, 2025
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 25, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 25, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/max-safe-lucas 49 / 49
+ 100.00 %
1 / 1
+ 100.00 %
0 / 0
+ 100.00 %
49 / 49
+ 100.00 %

The above coverage report was generated for the changes in this PR.

*
* @constant
* @type {integer}
* @default 1197222447
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrshya How did you come up with this number, 1197222447?
Actually, it must be:

In [5]: FLOAT32_MAX_SAFE_INTEGER > 12752043
Out[5]: true

In [6]: FLOAT32_MAX_SAFE_INTEGER > 20633239
Out[6]: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1197222447 isn't a Lucas number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, after double checking the correct value is indeed 12752043. Thanks for pointing that out

@hrshya hrshya requested a review from gunjjoshi March 26, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants