Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: execute stmt under cursor #257

Merged
merged 20 commits into from
Mar 30, 2025
Merged

feat: execute stmt under cursor #257

merged 20 commits into from
Mar 30, 2025

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Mar 22, 2025

closes #191

ok
ok
@juleswritescode juleswritescode marked this pull request as ready for review March 28, 2025 11:49
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of it are nits, but I think we should check if the statement is valid before offering the execution

Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 🙌

@juleswritescode juleswritescode merged commit ee45ea6 into main Mar 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back the commands crate
2 participants