fix(base): triggering beforeunload event may cause Uncaught null
#520
Conversation
nyannyacha
force-pushed
the
fix-beforeunload-uncaught-null
branch
from
0fdaf09 to
73a3218
Compare
|
ping @jumski: You be interested on this one |
|
Thanks for sharing @kallebysantos . I indeed encountered this error regularly, but have no idea how to reproduce it. Thanks for solving it @nyannyacha 😻 |
|
It's been a while @jumski 😁 |
|
Indeed @nyannyacha 😅 I was super focused on the SQL part lately, but it's done already 🥳 I will be working on updates to Edge Worker to make it work with pgflow soon, so will have a chance to test it again! |
|
@nyannyacha any clues to how to trigger it to verify? Other than spam-triggering onbeforeunload |
|
🎉 This PR is included in version 1.67.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@nyannyacha we need to backport this to Deno 2 release as well? |
|
@laktek yeah this should be backported to the develop branch as well. |
|
@jumski I think this is easily reproducible via a loop that invokes a function that consumes excessive CPU time. |
* chore: add old eszip migration test (#512) * chore(base): add a dependency * chore(base): add `.gitignore` * chore: add scripts * chore(ci): add a step that brings test eszip binaries * chore(base): update `.gitignore` * chore(base): add old eszip migration test * chore(base): add snapshots for old eszip migration tests * stamp(ci): change bucket name * stamp: update snapshots * stamp: polishing * fix(base): triggering `beforeunload` event may cause `Uncaught null` (#520) * fix(base): triggering `beforeunload` event may cause `Uncaught null` * chore: add an integration test
What kind of change does this PR introduce?
Bug fix
Description
Triggering
beforeunloadevent may causeUncaught nullerror due to resource limitation.Closes FUNC-205