Various small refactors #5260
Merged
Various small refactors #5260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofiOne
force-pushed
the
backport/various-small-refactors
branch
from
10adf1d to
25c0f9b
Compare
This is never inlined anyway, but duplicated into all modules using log_pipe_queue(), it is then better to just have it in one location. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
log_pipe_forward_msg() is not inlined anyway, so it will just add an extra branch. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
Checking the global variable pipe_single_step_hook is quite complicated as it is addressed $rip relative, so let's filter out the config related pipes first and remove the same check from the debugger. Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com> Signed-off-by: Hofi <hofione@gmail.com>
HofiOne
force-pushed
the
backport/various-small-refactors
branch
from
25c0f9b to
56ff9c5
Compare
kovgeri01
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of 368 by @alltilla