fix(HeaderCell): add unique keys to column grouping cells; #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neschadin
changed the title
|
Thanks for the PR. Should be fixed over here 8c10b01 in version 4.1.14. This PR had several other changes, so I couldn't merge it right away. Appreciate the work @Neschadin 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the React warning "Each child in a list should have a unique 'key' prop" that occurs when using the gridColumnStart and gridColumnEnd props in the HeaderCell component (which is also used in FooterCell). The issue was due to the generation of additional grouping cells without unique keys.
Changes:
Updated the column grouping rendering in HeaderCell to assign a unique key to each generated grouping cell.
This change addresses #158 & #167