Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #912: Support data_schema in CREATE EXTERNAL STREAM (Kafka) #913

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

KathrynLin
Copy link

Summary

This PR fixes the issue where data_schema was not recognized in CREATE EXTERNAL STREAM for Kafka.

Changes

  • Added data_schema to the ExternalStreamSettings.
  • Updated InterpreterCreateQuery to extract and apply data_schema.
  • Fixed schema auto-derivation from Avro format.
  • Modified ParserCreateQuery to properly handle data_schema.

Testing

  • Successfully created an external stream with data_schema:
    CREATE EXTERNAL STREAM example
    SETTINGS type = 'kafka',
             brokers = 'localhost:9092',
             topic = 'my-topic',
             data_format = 'Avro',
             data_schema = 'my_avro_schema';

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants