-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecmascript): TypedArrayCreateFromConstructor and %TypedArray%.of #601
feat(ecmascript): TypedArrayCreateFromConstructor and %TypedArray%.of #601
Conversation
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and great work!
Found some issues around GC, and we can split the method up a bit to make it cleaner in a sense. (Oh, we could also theoretically do a fast-path for when all the parameters given are numbers or bigints, depending on the TypedArray kind; in those cases we could probably mostly skip the whole Set
internal method. But that's involved and somewhat error prone, so let's leave that for another day! :D )
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Outdated
Show resolved
Hide resolved
21a4ab2
to
1f6430b
Compare
1f6430b
to
52aff10
Compare
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, sorry I lead you astray a bit.
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
…nal and implement with_buffer method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a bit smoothing of edges to do :)
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/typed_array_objects/abstract_operations.rs
Outdated
Show resolved
Hide resolved
.../ecmascript/builtins/indexed_collections/typed_array_objects/typed_array_intrinsic_object.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) but remove the index.js file before merging
ref: #145
doc: