-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useAxios): Add types and callback to handle AxiosError #4653
Open
michaelcozzolino
wants to merge
8
commits into
vueuse:main
Choose a base branch
from
michaelcozzolino:feat/typing-axios-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(useAxios): Add types and callback to handle AxiosError #4653
michaelcozzolino
wants to merge
8
commits into
vueuse:main
from
michaelcozzolino:feat/typing-axios-error
+57
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AxiosError and add additional computed property to get the AxiosError response data
OrbisK
reviewed
Mar 25, 2025
@@ -50,19 +57,19 @@ export interface UseAxiosReturn<T, R = AxiosResponse<T>, _D = any, O extends Use | |||
*/ | |||
isCanceled: Ref<boolean> | |||
} | |||
export interface StrictUseAxiosReturn<T, R, D, O extends UseAxiosOptions = UseAxiosOptions<T>> extends UseAxiosReturn<T, R, D, O> { | |||
export interface StrictUseAxiosReturn<T, R, D, AxiosErrorResponseData = unknown, O extends UseAxiosOptions<T, AxiosErrorResponseData> = UseAxiosOptions<T, AxiosErrorResponseData>> extends UseAxiosReturn<T, R, D, AxiosErrorResponseData, O> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this type is breaking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's unavoidable, do you have any suggestions to make it non breaking?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
This PR introduces a generic type system for the AxiosError, in detail:
axiosError
ref that will be populated only when theError
is an instance ofAxiosError
, furthermore when the error is not AxiosError, theerror
ref will still be populated, and I also added a callback (onAxiosError
) that will be executed only when we have anAxiosError
, if that is the case, also theonError
callback will be executed.AxiosError
, basically, according to me, the developer is mainly looking for thedata
property of the error response, and, also for consistency with thedata
property of a successfulAxiosResponse
, I added a computed propertyaxiosErrorResponseData
that returns exactly the data of the error response.Example usage
Additional context
If the feature is accepted, I will add tests and update the docs. There is no breaking change in the composable, but only in the types, as it seems unavoidable.
Let me know if the naming is fine, I think they are pretty descriptive, but I'm looking forward to suggestions, if any.