This repository was archived by the owner on Mar 16, 2019. It is now read-only.
bug: UIApplication methods are called on background thread #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As long as RNFetchBlob is called inside of a mounted component, the issue doesn't present itself. However, if one of these methods are called from outside a mounted component, Xcode will complain about
setNetworkActivityIndicatorVisible
being called from a background thread:Best practice is to always wrap these methods in a
dispatch_async
call to ensure they are called on the foreground thread.