Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

Catch IllegalArgumentException when external storage directory doesn't exist #609

Closed
wants to merge 1 commit into from
Closed

Catch IllegalArgumentException when external storage directory doesn't exist #609

wants to merge 1 commit into from

Conversation

RalfNieuwenhuizen
Copy link

Thank you for making a pull request ! Just a gentle reminder :)

  1. If the PR is offering a feature please make the request to our "Feature Branch" 0.11.0
  2. Bug fix request to "Bug Fix Branch" 0.10.9
  3. Correct README.md can directly to master

@RalfNieuwenhuizen
Copy link
Author

@lll000111 do you feel like merging this? I guess it won't harm anything. Tested and running since november.

@lll000111
Copy link
Contributor

lll000111 commented Mar 20, 2018

@RalfNieuwenhuizen See the README. I could merge some PRs (but not even my own! They still need a review from the actual owner!) I don't want to be responsible for anything. I'm not the owner and I cannot replace him. I was made "Collaborator" because at the time I submitted a few patches before I could say "No". I don't even do mobile development! I was willing to help out but only with filesystem related stuff that I needed myself. I can't be the maintainer around here. Somebody has to folk the repo and become the new maintainer. I'm not going top merge something I cannot even test, the original owner has another repo with a test infrastructure. I don't even own a "smart phone, that's how badly positioned I am for this project!

Oh and I can only merge to master, and I certainly don't want any new code in there. If I could do it at all I would merge to the 0.10.9 branch but Github does not offer me that choice.

@lll000111
Copy link
Contributor

lll000111 commented Mar 20, 2018

Ah I see (my git skills are not very advanced to say the least so I had to check), about my last sentence, PRs should not be for master but for the 0.10.9 branch in any case, so even if I would do maintenance on this project I would have to reject it :-(

@RalfNieuwenhuizen
Copy link
Author

Thanks for your explanation. I'll be patient.

@lll000111
Copy link
Contributor

FYI

react-native-fetch-blob has a new maintained location. Check out the README.

Please consider submitting your PR there, this repository is unmaintained.

NOTE: Patches should be against the current development branch, not against master.

@RalfNieuwenhuizen RalfNieuwenhuizen closed this by deleting the head repository Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants