-
Notifications
You must be signed in to change notification settings - Fork 479
BUDA: support multithread apps #6414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…a_docker_wrapper12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the Docker wrapper version to 7 across build/config files, adds a new nthreads_cmdline
XML setting, and refactors several sample applications and utilities to use new constants and improve robustness.
- Bump Docker wrapper release to 7 in project files and scripts
- Add
<nthreads_cmdline>
setting to plan_class XML - Refactor multi-thread and Docker wrapper samples for clearer constants, improved parsing, and STANDALONE support
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
win_build/docker_wrapper.vcxproj | Updated <TargetVersion> from 6 to 7 |
version.h | Bumped DOCKERWRAPPER_RELEASE to 7, removed WSL_WRAPPER_RELEASE |
sched/plan_class_spec.xml.sample | Added <nthreads_cmdline> element |
samples/multi_thread/multi_thread.cpp | Replaced TOTAL_UNITS with UNITS_PER_THREAD , added STANDALONE guard |
samples/multi_thread/Makefile | Renamed PROGS to PROG , updated build target |
samples/docker_wrapper/docker_wrapper.cpp | Added --cpus flag, robust stats parsing, fixed fprintf call |
lib/str_util.cpp | Modified split to append delimiter |
html/user/buda.php | Reordered handling of output_file_names |
configure.ac | Bumped DOCKERWRAPPER_RELEASE to 7 |
Comments suppressed due to low confidence (3)
sched/plan_class_spec.xml.sample:7
- A new
<nthreads_cmdline>
element was added—please update the plan_class_spec documentation to describe its purpose and valid values.
<nthreads_cmdline> 1 </nthreads_cmdline>
version.h:32
- The WSL_WRAPPER_RELEASE macro was removed but may still be used elsewhere; please reintroduce
#define WSL_WRAPPER_RELEASE 4
(or appropriate version) before bumping DOCKERWRAPPER_RELEASE.
// dockerwrapper version number
lib/str_util.cpp:842
- Appending the delimiter to each split item changes the expected behavior of
split
; most consumers expect the delimiter to be removed. Consider pushingitem
alone.
result.push_back(item+delim);
samples/multi_thread/Makefile
Outdated
@@ -41,7 +41,7 @@ clean: distclean | |||
distclean: | |||
/bin/rm -f $(PROGS) $(addsuffix .exe, $(PROGS)) *.o libstdc++.a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distclean
rule still references $(PROGS)
which is no longer defined; update it to use $(PROG)
so the generated binary is cleaned up correctly.
/bin/rm -f $(PROGS) $(addsuffix .exe, $(PROGS)) *.o libstdc++.a | |
/bin/rm -f $(PROG) $(addsuffix .exe, $(PROG)) *.o libstdc++.a |
Copilot uses AI. Check for mistakes.
int units_per_thread; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The units_per_thread
variable is no longer used after switching to the UNITS_PER_THREAD
constant; consider removing this declaration to avoid confusion.
int units_per_thread; |
Copilot uses AI. Check for mistakes.
bool found = false; | ||
double cpu_pct=0, mem=0; | ||
char mem_unit=0; | ||
for (string line: out) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Iterating by value causes unnecessary string copies; prefer for (const string& line : out)
to avoid allocations.
for (string line: out) { | |
for (const string& line : out) { |
Copilot uses AI. Check for mistakes.
…ipt. Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
…ersion.h file with the script Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
BUDA: support multithread apps
docker wrapper
skip it to parse CPU time correctly
multi_thread (test app)
web (job submission)
plan class XML spec: