Skip to content

Issue with the ansible-lint #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y0rune opened this issue Jan 21, 2023 · 2 comments
Open

Issue with the ansible-lint #426

y0rune opened this issue Jan 21, 2023 · 2 comments

Comments

@y0rune
Copy link
Contributor

y0rune commented Jan 21, 2023

I found out that when I added the new commit into a specific branch the workflow check diff from that commit into a master latest branch.
For example:
When I added the new commit into a #409 It chacked a lot of files:
Link to action: https://github.com/CiscoDevNet/ansible-meraki/actions/runs/3976255493/jobs/6816623260
image

y0rune added a commit to y0rune/ansible-meraki that referenced this issue Jan 21, 2023
kbreit pushed a commit that referenced this issue Jan 21, 2023
@y0rune y0rune closed this as completed Jan 21, 2023
@y0rune y0rune reopened this Jan 21, 2023
@y0rune
Copy link
Contributor Author

y0rune commented Jan 21, 2023

That issue is still occurred due to fetch.
Resolved in #430.

Source of that fix:
actions/checkout#552 (comment)

EDIT: Fetching to a common ancestor may fail when you have commits belonging to the base branch in local history which have not been merged into the PR branch. This problem occurs with the default ref (the generated test merge-commit of the PR branch into the base branch) with a fetch-depth of 2 or more.

When I tested a new PR it worked (https://github.com/y0rune/ansible-meraki/actions/runs/3977154163/jobs/6818062752)

@y0rune
Copy link
Contributor Author

y0rune commented Jan 22, 2023

Still that error occurred. (https://github.com/CiscoDevNet/ansible-meraki/actions/runs/3981709537/jobs/6825621898)
image

I think we cannot do it due to specific of that plug. I did not know if we can enable to do it (@kbreit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant