Skip to content

chore: update activityCount threshold to match enrichment specs #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 18, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
-- backup members table
create table members_backup_16_06_2025 as
select *
from members
with no data;

-- Copy all data
insert into members_backup_16_06_2025
select *
from members;

-- backup memberIdentities table
create table member_identities_backup_16_06_2025 as
select *
from "memberIdentities"
with no data;

-- Copy all data
insert into member_identities_backup_16_06_2025
select *
from "memberIdentities";

-- backup memberOrganizations table
create table member_organizations_backup_16_06_2025 as
select *
from "memberOrganizations"
with no data;

-- Copy all data
insert into member_organizations_backup_16_06_2025
select *
from "memberOrganizations";
Original file line number Diff line number Diff line change
@@ -348,11 +348,23 @@ export async function updateMemberUsingSquashedPayload(
}

for (const org of squashedPayload.memberOrganizations.filter((o) => !o.organizationId)) {
// Skip organizations that don't have a name or any verified identities
const identities = org.identities ? org.identities : []
const verifiedIdentities = identities.filter((i) => i.verified)

if (!org.name && verifiedIdentities.length === 0) {
svc.log.debug(
{ orgId: org.organizationId },
'Skipping organization without name or verified identities',
)
continue
}

orgPromises.push(
findOrCreateOrganization(qx, OrganizationAttributeSource.ENRICHMENT, {
displayName: org.name,
description: org.organizationDescription,
identities: org.identities ? org.identities : [],
identities,
})
.then((orgId) => {
// set the organization id for later use
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ import {
export default class EnrichmentServiceClearbit extends LoggerBase implements IEnrichmentService {
public source: MemberEnrichmentSource = MemberEnrichmentSource.CLEARBIT
public platform = `enrichment-${this.source}`
public enrichMembersWithActivityMoreThan = 10
public enrichMembersWithActivityMoreThan = 100

public enrichableBySql = `"membersGlobalActivityCount".total_count > ${this.enrichMembersWithActivityMoreThan} AND mi.type = 'email' and mi.verified`

Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ export default class EnrichmentServiceCrustdata extends LoggerBase implements IE
MemberEnrichmentSource.SERP,
]

public enrichMembersWithActivityMoreThan = 1000
public enrichMembersWithActivityMoreThan = 100

public enrichableBySql = `("membersGlobalActivityCount".total_count > ${this.enrichMembersWithActivityMoreThan}) AND mi.verified AND mi.type = 'username' and mi.platform = 'linkedin'`

@@ -61,11 +61,20 @@ export default class EnrichmentServiceCrustdata extends LoggerBase implements IE
},
[MemberAttributeName.SKILLS]: {
fields: ['skills'],
transform: (skills: string) =>
skills
.split(',')
// Note: Crustdata API docs specify skills as string, but API returns string[]
// So we're handling both cases in the transformer.
transform: (skills: string | string[]) => {
if (!skills) {
return []
}

const arr = Array.isArray(skills) ? skills : skills.split(',')

return arr
.map((s) => s.trim())
.sort(),
.filter(Boolean)
.sort()
},
},
[MemberAttributeName.LANGUAGES]: {
fields: ['languages'],
@@ -151,20 +160,37 @@ export default class EnrichmentServiceCrustdata extends LoggerBase implements IE
private async getDataUsingLinkedinHandle(
handle: string,
): Promise<IMemberEnrichmentDataCrustdata> {
const url = `${process.env['CROWD_ENRICHMENT_CRUSTDATA_URL']}/screener/person/enrich`
const config = {
method: 'get',
url,
params: {
linkedin_profile_url: `https://linkedin.com/in/${handle}`,
enrich_realtime: true,
},
headers: {
Authorization: `Token ${process.env['CROWD_ENRICHMENT_CRUSTDATA_API_KEY']}`,
},
}
let response: IMemberEnrichmentCrustdataAPIResponse[]

const response: IMemberEnrichmentCrustdataAPIResponse[] = (await axios(config)).data
try {
const url = `${process.env['CROWD_ENRICHMENT_CRUSTDATA_URL']}/screener/person/enrich`
const config = {
method: 'get',
url,
params: {
linkedin_profile_url: `https://linkedin.com/in/${handle}`,
enrich_realtime: true,
},
headers: {
Authorization: `Token ${process.env['CROWD_ENRICHMENT_CRUSTDATA_API_KEY']}`,
},
validateStatus: function (status) {
return (status >= 200 && status < 300) || status === 404 || status === 422
},
}

response = (await axios(config)).data
} catch (err) {
if (axios.isAxiosError(err)) {
this.log.warn(
`Axios error occurred while getting Crustdata data: ${err.response?.status} - ${err.response?.statusText}`,
)
throw new Error(`Crustdata enrichment request failed with status: ${err.response?.status}`)
} else {
this.log.error(`Unexpected error while getting Crustdata data: ${err}`)
throw new Error('An unexpected error occurred')
}
}

if (response.length === 0 || this.isErrorResponse(response[0])) {
return null
Original file line number Diff line number Diff line change
@@ -140,7 +140,7 @@ export async function fetchMembersForEnrichment(
LEFT JOIN "membersGlobalActivityCount" ON "membersGlobalActivityCount"."memberId" = members.id
WHERE
${enrichableBySqlJoined}
AND coalesce((m.attributes ->'isBot'->>'default')::boolean, false) = false
AND coalesce((members.attributes ->'isBot'->>'default')::boolean, false) = false
AND members."deletedAt" IS NULL
AND (${cacheAgeInnerQueryItems.join(' OR ')})
GROUP BY members.id
@@ -295,7 +295,7 @@ export async function setMemberEnrichmentUpdateDate(

export async function resetMemberEnrichmentTry(tx: DbConnOrTx, memberId: string): Promise<void> {
await tx.none(
`update "memberEnrichments" set "lastTriedAt" = null where "memberId" = $(memberId)`,
`update "memberEnrichments" set "lastTriedAt" = now() where "memberId" = $(memberId)`,
{ memberId },
)
}
Loading
Oops, something went wrong.