Adopt dataType for Literals and preparedValues #3395
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves away from using
java.sql.Types
in the internals offdb-relational-core
, while still maintaining JDBC-compliance for externalgetType()
-like operations. It is replaced withDataType
, which provides richer and more diverse type information available for downstream operations. Notably, we can now have types likeUuid
,Enum
,Version
expressed natively. There are several consequences of this:StructMetadata
andArrayMetadata
wrapDataType
as the source of truth for their type info. However, they still map tosql.Types
externally. Moreover, they now exposegetRelationalDataType()
that returnsDataType
to the external users for more transparency.grpc
protobufs now have aType
enum, moving away fromsql.Types
too. This was needed to supportstruct
andarray
operations homogenously across embedded and JDBC drivers. It keeps the old types too for backward compatibility, which I think should be removed in future to simplify conversions.