fix: use validated package.json version in manifest (#147)

Closes #139

Author: mcous

dist/main.js

@@ -38,6 +38,20 @@ describe("readManifest", () => {
     });
   });
 
+  it("should normalize the version field", async () => {
+    await fs.writeFile(
+      path.join(directory, "package.json"),
+      JSON.stringify({ name: "cool-name", version: "v1.2.3" }),
+      "utf8"
+    );
+
+    const result = await subject.readManifest(
+      path.join(directory, "package.json")
+    );
+
+    expect(result).toMatchObject({ version: "1.2.3" });
+  });
+
   it("should read a package.json file in a directory", async () => {
     await fs.writeFile(
       path.join(directory, "package.json"),

dist/main.js.map

@@ -39,8 +39,8 @@ const isTarball = (file: unknown): file is string => {
   return typeof file === "string" && path.extname(file) === TARBALL_EXTNAME;
 };
 
-const isVersion = (version: unknown): version is string => {
-  return semverValid(version as string) !== null;
+const validateVersion = (version: unknown): string | undefined => {
+  return semverValid(version as string) ?? undefined;
 };
 
 const readPackageJson = async (...pathSegments: string[]): Promise<string> => {
@@ -110,7 +110,7 @@ export async function readManifest(
   try {
     manifestJson = JSON.parse(manifestContents) as Record<string, unknown>;
     name = manifestJson["name"];
-    version = manifestJson["version"];
+    version = validateVersion(manifestJson["version"]);
     publishConfig = manifestJson["publishConfig"] ?? {};
   } catch (error) {
     throw new errors.PackageJsonParseError(packageSpec, error);
@@ -120,7 +120,7 @@ export async function readManifest(
     throw new errors.InvalidPackageNameError(name);
   }
 
-  if (!isVersion(version)) {
+  if (typeof version !== "string") {
     throw new errors.InvalidPackageVersionError(version);
   }