refactor: pull side effect out of action bundle import (#115)

Author: mcous

action.js

@@ -0,0 +1,6 @@
+/* eslint-disable @typescript-eslint/no-floating-promises, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call */
+"use strict";
+
+const { main } = require("./dist/main.js");
+
+main();

action.yaml

@@ -93,4 +93,4 @@ outputs:
 
 runs:
   using: node16
-  main: dist/main.js
+  main: action.js

dist/main.js

@@ -19,6 +19,7 @@
     "type": "git",
     "url": "https://github.com/JS-DevTools/npm-publish.git"
   },
+  "type": "commonjs",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "bin": {
@@ -72,10 +73,9 @@
     "prettier": "^2.8.8",
     "prettier-plugin-jsdoc": "^0.4.2",
     "rimraf": "^5.0.0",
-    "testdouble": "^3.17.2",
-    "testdouble-vitest": "^0.1.2",
     "typescript": "^5.0.4",
-    "vitest": "^0.32.4"
+    "vitest": "^0.32.4",
+    "vitest-when": "^0.1.2"
   },
   "dependencies": {
     "@types/semver": "^7.5.0",

dist/main.js.map

@@ -1,6 +1,5 @@
-import { vi, describe, it, afterEach, expect } from "vitest";
-import { imitateEsm, reset } from "testdouble-vitest";
-import * as td from "testdouble";
+import { vi, describe, it, expect } from "vitest";
+import { when } from "vitest-when";
 
 import * as subject from "../npm-publish.js";
 import { readManifest, type PackageManifest } from "../read-manifest.js";
@@ -15,16 +14,12 @@ import {
 } from "../compare-and-publish/index.js";
 import type { Logger, Options } from "../options.js";
 
-vi.mock("../read-manifest", () => imitateEsm("../read-manifest"));
-vi.mock("../normalize-options", () => imitateEsm("../normalize-options"));
-vi.mock("../npm", () => imitateEsm("../npm"));
-vi.mock("../compare-and-publish", () => imitateEsm("../compare-and-publish"));
+vi.mock("../read-manifest");
+vi.mock("../normalize-options");
+vi.mock("../npm");
+vi.mock("../compare-and-publish");
 
 describe("npmPublish", () => {
-  afterEach(() => {
-    reset();
-  });
-
   it("should read the manifest, get publish config, compare, and publish", async () => {
     const options: Options = { package: "./cool-package", token: "abc123" };
 
@@ -46,11 +41,13 @@ describe("npmPublish", () => {
       oldVersion: "0.1.2",
     };
 
-    td.when(readManifest("./cool-package")).thenResolve(manifest);
-    td.when(normalizeOptions(manifest, options)).thenReturn(normalizedOptions);
-    td.when(
-      useNpmEnvironment(manifest, normalizedOptions, compareAndPublish)
-    ).thenResolve(publishResult);
+    when(readManifest).calledWith("./cool-package").thenResolve(manifest);
+    when(normalizeOptions)
+      .calledWith(manifest, options)
+      .thenReturn(normalizedOptions);
+    when(useNpmEnvironment<PublishResult>)
+      .calledWith(manifest, normalizedOptions, compareAndPublish)
+      .thenResolve(publishResult);
 
     const result = await subject.npmPublish(options);