Skip to content

Initial publish #11

Closed
Closed
@nikitaeverywhere

Description

@nikitaeverywhere
Contributor

Hello! Thanks for the great action.

I noticed it always fails saying

##[error]Error: Unable to determine the current version of @pkg/NAME on NPM. 

...when you do a first publish of the package (when you're just starting a repository). You need to manually push the first version, and then it will work.

Is it intended or can be fixed? I guess we can add an error handler here.

Thank you.

Activity

JamesMessinger

JamesMessinger commented on Sep 7, 2020

@JamesMessinger
Member

Good catch. I never thought about that because in my workflow the initial publish is usually done manually, not by CI/CD. But it makes total sense that this package should support that use case.

I'll leave this issue open and mark it as a bug to be fixed. I may not have the time to fix it for a while, but you're welcome to submit a PR if you have the time.

added 2 commits that reference this issue on Sep 7, 2020
f46633e
610099a
added 2 commits that reference this issue on Sep 7, 2020
02ef1cd
2656c73
nikitaeverywhere

nikitaeverywhere commented on Sep 7, 2020

@nikitaeverywhere
ContributorAuthor

Here we go!

nikitaeverywhere

nikitaeverywhere commented on Sep 9, 2020

@nikitaeverywhere
ContributorAuthor

Ping @JamesMessinger there seems to be 2 PRs already to fix it, please review 😁

varunsridharan

varunsridharan commented on Sep 28, 2020

@varunsridharan

@JamesMessinger great action. and i really need this feature. and waiting for your review on (#12 #13 ) pull request.

added a commit that references this issue on Sep 28, 2020

Merge pull request #1 from ZitRos/patch-2

71bb259
added a commit that references this issue on Oct 1, 2020

Merge pull request #12 from ZitRos/patch-2

e26eb1d

4 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @varunsridharan@JamesMessinger@nikitaeverywhere@ShadyNagy

      Issue actions

        Initial publish · Issue #11 · JS-DevTools/npm-publish