Skip to content

Conversation

@hamnis
Copy link

@hamnis hamnis commented Apr 5, 2025

Should fix https://youtrack.jetbrains.com/issue/SCL-21024/Use-a-locally-installed-bloop-with-provided-connection-file#focus=Comments-27-11406726.0-0

  • Remove old bloop launcher
  • Fix some warnings which became errors in the build, by adding @scala.annotation.nowarn("cat=deprecation") where needed.

TODO:

  • Make the bloop version configurable.

Should fix https://youtrack.jetbrains.com/issue/SCL-21024/Use-a-locally-installed-bloop-with-provided-connection-file#focus=Comments-27-11406726.0-0

* Remove old bloop launcher
* Fix some warnings which became errors in the build, by adding @scala.annotation.nowarn("cat=deprecation") where needed.

TODO:
* Make the bloop version configurable.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont understand why this file was edited at all.

@azdrojowa123
Copy link
Contributor

Hello,
I apologize for the late response.
I was able to reproduce the issue on an m1 machine. From what I've checked, it can be fixed simply by upgrading from bloop-launcher_2.12 1.5.6 to bloop-launcher-core_2.12 1.6.0. Such a fix would be much simpler. Does this solution also work for you?

I noticed that you used the new bloop rifle. What are the practical benefits of using it?

@hamnis
Copy link
Author

hamnis commented Sep 1, 2025

The bloop-launcher is no longer maintained, and is replaced by bloop-rifle.

unkarjedy pushed a commit that referenced this pull request Sep 2, 2025
@azdrojowa123
Copy link
Contributor

azdrojowa123 commented Sep 3, 2025

Hello,
The fix from this PR has been merged via JetBrains internal tools, but I slightly minimized it by removing the transitive dependencies to the newer version of bsp4j. It's the commit.

The fix will be available in the next 2025.2 nightly version. If you're not using nightly versions, you can enable them in the Settings | Languages & Frameworks | Scala | Updates settings.

Thank you again for the contribution.

@azdrojowa123
Copy link
Contributor

Because this PR is merged, SCL-21024 is also marked as "fixed".

At the bottom of SCL-21024, there is a note incorrectly indicating that the PR was declined. This happened because the cherry-pick wasn't done with your changes, although they are explicitly mentioned in the merged commit.

@hamnis
Copy link
Author

hamnis commented Sep 3, 2025

Great news. Thanks a lot!

@hamnis hamnis deleted the bloop-rifle branch September 3, 2025 10:49
unkarjedy pushed a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants