-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Bug]: Networks - Selecting Solana on the Login screen, breaks the wallet with the error Message: Cannot read properties of undefined (reading 'metadata')
#33240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
regression-RC-12.20.0
Regression bug that was found in release candidate (RC) for release 12.20.0
release-12.21.0
Issue or pull request that will be included in release 12.21.0
release-blocker
This bug is blocking the next release
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-accounts
type-bug
Something isn't working
Comments
Message: Cannot read properties of undefined (reading 'metadata')
Message: Cannot read properties of undefined (reading 'metadata')
Adding the regression-RC-12.9.0 label, to keep track of the blocker, otherwise this issue will be lost as won't appear in the 12.19 tracker |
Message: Cannot read properties of undefined (reading 'metadata')
Message: Cannot read properties of undefined (reading 'metadata')
Present in v12.20.0: Screen.Recording.2025-05-30.at.16.36.31.mov |
This relates to |
Screen.Recording.2025-06-03.at.4.30.22.PM.movHi @seaona @Unik0rnMaggie, is there a config I'm missing? Can't see the network picker on the locked screen |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Jun 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33481?quickstart=1) Disable non EVM networks on locked screen ## **Related issues** Fixes: #33240 ## **Manual testing steps** 1. Onboard 2. Lock metamask 3. Try to switch to Solana network 4. The network should be disabled ## **Screenshots/Recordings** ### **Before** Check #33240 ### **After** <img width="700" alt="Screenshot 2025-06-04 at 3 11 09 PM" src="https://github.com/user-attachments/assets/8627d053-51c2-4809-9ea4-7c5ef7733fc1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this issue
Jun 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33481?quickstart=1) Disable non EVM networks on locked screen ## **Related issues** Fixes: #33240 ## **Manual testing steps** 1. Onboard 2. Lock metamask 3. Try to switch to Solana network 4. The network should be disabled ## **Screenshots/Recordings** ### **Before** Check #33240 ### **After** <img width="700" alt="Screenshot 2025-06-04 at 3 11 09 PM" src="https://github.com/user-attachments/assets/8627d053-51c2-4809-9ea4-7c5ef7733fc1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
added a commit
that referenced
this issue
Jun 5, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33481?quickstart=1) Disable non EVM networks on locked screen ## **Related issues** Fixes: #33240 ## **Manual testing steps** 1. Onboard 2. Lock metamask 3. Try to switch to Solana network 4. The network should be disabled ## **Screenshots/Recordings** ### **Before** Check #33240 ### **After** <img width="700" alt="Screenshot 2025-06-04 at 3 11 09 PM" src="https://github.com/user-attachments/assets/8627d053-51c2-4809-9ea4-7c5ef7733fc1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
runway-github bot
pushed a commit
that referenced
this issue
Jun 5, 2025
…reen cp-12.20.0 (#33481) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33481?quickstart=1) Disable non EVM networks on locked screen ## **Related issues** Fixes: #33240 ## **Manual testing steps** 1. Onboard 2. Lock metamask 3. Try to switch to Solana network 4. The network should be disabled ## **Screenshots/Recordings** ### **Before** Check #33240 ### **After** <img width="700" alt="Screenshot 2025-06-04 at 3 11 09 PM" src="https://github.com/user-attachments/assets/8627d053-51c2-4809-9ea4-7c5ef7733fc1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
DDDDDanica
added a commit
that referenced
this issue
Jun 5, 2025
…reen cp-12.20.0 (#33501) - fix: disable non EVM networks on locked screen cp-12.20.0 (#33481) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33481?quickstart=1) Disable non EVM networks on locked screen ## **Related issues** Fixes: #33240 ## **Manual testing steps** 1. Onboard 2. Lock metamask 3. Try to switch to Solana network 4. The network should be disabled ## **Screenshots/Recordings** ### **Before** Check #33240 ### **After** <img width="700" alt="Screenshot 2025-06-04 at 3 11 09 PM" src="https://github.com/user-attachments/assets/8627d053-51c2-4809-9ea4-7c5ef7733fc1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [ac99164](ac99164) --------- Co-authored-by: Gustavo Antunes <17601467+gantunesr@users.noreply.github.com> Co-authored-by: Danica Shen <zhaodanica@gmail.com>
mathieuartu
pushed a commit
that referenced
this issue
Jun 10, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/33481?quickstart=1) Disable non EVM networks on locked screen ## **Related issues** Fixes: #33240 ## **Manual testing steps** 1. Onboard 2. Lock metamask 3. Try to switch to Solana network 4. The network should be disabled ## **Screenshots/Recordings** ### **Before** Check #33240 ### **After** <img width="700" alt="Screenshot 2025-06-04 at 3 11 09 PM" src="https://github.com/user-attachments/assets/8627d053-51c2-4809-9ea4-7c5ef7733fc1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
regression-RC-12.20.0
Regression bug that was found in release candidate (RC) for release 12.20.0
release-12.21.0
Issue or pull request that will be included in release 12.21.0
release-blocker
This bug is blocking the next release
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-accounts
type-bug
Something isn't working
Uh oh!
There was an error while loading. Please reload this page.
Describe the bug
Wallet breaks with the error
Message: Cannot read properties of undefined (reading 'metadata')
Expected behavior
In 12.18.0 we disabled Solana on the login network picker
Screenshots/Recordings
reading-metadata.mp4
Steps to reproduce
Error messages or log output
Detection stage
On a feature branch
Version
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: