-
Notifications
You must be signed in to change notification settings - Fork 5.2k
chore: add remote feature flag for multichain accounts #33112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+210
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [b1e466e]
UI Startup Metrics (1217 ± 65 ms)
Benchmark value 831 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 25 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 44 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1625 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1412 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1412 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 1392 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 1979 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1766 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1765 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 1739 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 32 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 151ms | Sum of p95 exceeds: 611ms Sum of all benchmark exceeds: 762ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ee8a2c1]
UI Startup Metrics (1216 ± 81 ms)
Benchmark value 34 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 33 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 269 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Sum of mean exceeds: 2ms | Sum of p95 exceeds: 210ms Sum of all benchmark exceeds: 212ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
shane-t
previously approved these changes
May 22, 2025
owencraston
previously approved these changes
May 22, 2025
montelaidev
previously approved these changes
May 22, 2025
Builds ready [7701868]
UI Startup Metrics (1207 ± 66 ms)
Benchmark value 2467 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 5ms | Sum of p95 exceeds: 249ms Sum of all benchmark exceeds: 254ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
8021ab9
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (3 files, +209 -0)
|
Builds ready [1beaf8c]
UI Startup Metrics (1230 ± 66 ms)
Benchmark value 44 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2469 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 301 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 29 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Sum of mean exceeds: 15ms | Sum of p95 exceeds: 261ms Sum of all benchmark exceeds: 276ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [df0fc64]
UI Startup Metrics (1221 ± 68 ms)
Benchmark value 2515 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Sum of mean exceeds: 0ms | Sum of p95 exceeds: 73ms Sum of all benchmark exceeds: 73ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
May 27, 2025
Builds ready [5eb39a3]
UI Startup Metrics (1222 ± 74 ms)
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 40 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 305 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1735 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1580 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1580 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 26 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 1555 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 11ms | Sum of p95 exceeds: 572ms Sum of all benchmark exceeds: 583ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ccharly
reviewed
May 28, 2025
Builds ready [44e143c]
UI Startup Metrics (1213 ± 76 ms)
Benchmark value 38 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2470 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 304 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 9ms | Sum of p95 exceeds: 260ms Sum of all benchmark exceeds: 269ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [2adc168]
UI Startup Metrics (1204 ± 62 ms)
Benchmark value 2226 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1720 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1713 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 1709 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 43 exceeds gate value 32 for chrome webpack home mean setupStore Benchmark value 2552 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 306 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 1705 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 41 exceeds gate value 38 for firefox webpack home mean firstReactRender Sum of mean exceeds: 78ms | Sum of p95 exceeds: 394ms Sum of all benchmark exceeds: 472ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
owencraston
approved these changes
May 28, 2025
montelaidev
approved these changes
May 29, 2025
shane-t
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add remote feature flag for multichain accounts. The feature flag structure is,
Related issues
Fixes: None
Manual testing steps
Not applicable
Screenshots/Recordings
applicable
Pre-merge author checklist
Pre-merge reviewer checklist