Fix race conditions in temporary file creation #13352
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race conditions in temporary file creation
Replace weak random number generation with atomic counters and implement
retry loops to handle EEXIST errors in four locations:
optimise-store.cc: Fix race in temporary hard link creation
indirect-root-store.cc: Fix race in temporary symlink creation
local-store.cc: Fix race in build log creation
local-binary-cache-store.cc: Fix race in cache file creation
All fixes use the existing makeTempPath() utility which provides atomic
counter + getpid() based unique name generation. All locations ensure
proper SysError exceptions are thrown instead of propagating
std::filesystem errors.
Motivation
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.