Skip to content

Modified default mutable arguments #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

svenkat19
Copy link

No description provided.

@chavarera chavarera assigned chavarera and svenkat19 and unassigned chavarera Jul 16, 2021
@chavarera
Copy link
Member

@svenkat19 any update?

@svenkat19
Copy link
Author

@svenkat19 any update?

Oh sorry, I just forgot to inform, Could you please explain where the doc-string document is?

@chavarera
Copy link
Member

@svenkat19 any update?

Oh sorry, I just forgot to inform, Could you please explain where the doc-string document is?

In same code the documentation added please update

@svenkat19
Copy link
Author

text_exclude already had a description I suppose!

@chavarera
Copy link
Member

chavarera commented Jul 18, 2021

text_exclude : list of values to exclude from result

Here Instead of list put it as immutable object tuple ..

@chavarera
Copy link
Member

chavarera commented Jul 19, 2021

@svenkat19 after modification of code please run the test case so it will validate your code block properly working or not.

If something breaking please modify accordingly

@svenkat19
Copy link
Author

I went through the cchanges, I am not able to find where I am going wrong. Could you help?

@chavarera
Copy link
Member

I went through the cchanges, I am not able to find where I am going wrong. Could you help?

@svenkat19

if text not in text_exclude:

consider if we not passing text_exclude value then above line will generate following exceptions

TypeError: argument of type 'NoneType' is not iterable

before iteration we need to compare the value

if text_exclude and text not in text_exclude:
    #perform regular operation

After completion of code run your code with

pytest

After all testcases passed then push

if you have still doubt comment it

@chavarera
Copy link
Member

closing PR

Reason: No update

@chavarera chavarera closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants