Skip to content

Exercise 6 repeat string: Put info about .skip tests in readme #542

Closed
@Jacksonbryan28

Description

@Jacksonbryan28

Prerequisites

  • I have thoroughly read and understand The Odin Project Contributing Guide
    I have searched the existing issues to ensure this improvement hasn't been suggested before (please have a look through our open issues list to make sure)
    The title of this issue follows the <Location of the improvement>: <Brief description of the improvement> format, e.g. Exercises: Add exercise on XYZ
    (Optional) I am interested in working on this issue and would like to be assigned to it

Improvement Description

In the javascript-exercises file you pick up on lesson 6. In the lesson 7 readme there is the following paragraph -

You will notice in this exercise that there are multiple tests (in the file reverseString.spec.js). Currently, only the first test is enabled. After ensuring that the first test passes, enable the remaining tests one by one by removing the .skip from the test.skip() function.

I suggest moving this into lesson 6 since lesson 6 also has multiple test with .skip applied. I wasn't sure what to do, or why so many tests were being skipped when running npm test for lesson 6.

Acceptance Criteria

  • the paragraph explaining .skip and how to use multiple skips is moved from lesson 7 into lesson 6 so it appears when you first encounter it.

(Optional) Additional Comments

No response

Activity

CouchofTomato

CouchofTomato commented on May 12, 2025

@CouchofTomato
Member

@TheOdinProject/javascript Can someone take a look please

MaoShizhong

MaoShizhong commented on May 13, 2025

@MaoShizhong
Contributor

Personally, I'd suggest that that paragraph in exercise 7 gets removed entirely. Instructions for handling skipped tests are already in the repo README and reminded in exercise 3's README where they first appear, so there's no reason for it to reappear in exercise 7 randomly.

Context was #509 where the skipped test instructions were part of exercise 6, as it used to be exercise 2. That was appropriately removed when the new exercises were added, but since Eduardo didn't expect exercise 3 (now 7) to also have that reminder, that didn't get removed along with the rest.

CouchofTomato

CouchofTomato commented on May 14, 2025

@CouchofTomato
Member

@Jacksonbryan28 Are you in agreement on this proposed change and still want to work on it?

Jacksonbryan28

Jacksonbryan28 commented on May 16, 2025

@Jacksonbryan28
Author

I think that sounds good. I accidentally skipped 1-6, so I didn't see it on exercise 3 (oops).

I probably shouldn't have marked that I can work on it since I don't really know how. I am still wrapping up foundations. If someone wants to pick it up instead, that would be cool.

MaoShizhong

MaoShizhong commented on May 16, 2025

@MaoShizhong
Contributor

Happy to pick this up then if you'd prefer.

Jacksonbryan28

Jacksonbryan28 commented on May 22, 2025

@Jacksonbryan28
Author

That would be great! Sorry for the slow response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: Needs ReviewThis issue/PR needs an initial or additional review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @CouchofTomato@MaoShizhong@Jacksonbryan28

      Issue actions

        Exercise 6 repeat string: Put info about .skip tests in readme · Issue #542 · TheOdinProject/javascript-exercises