Skip pthread_cond_busywait test in browser tests
#589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pthread_cond` test uses `nanosleep` which eventually calls `poll_oneoff` but `@bjorn3/browser_wasi_shim` does not implement it. So we skip the test for now, but we will revisit it later once bjorn3/browser_wasi_shim#88 is merged.
|
Thanks! |
|
bjorn3/browser_wasi_shim#88 has been merged. By the way, maybe it would be nice to run wasi-libc's test suite in browser_wasi_shim's CI too? |
kateinoigakukun
added a commit
to kateinoigakukun/wasi-libc
that referenced
this pull request
Jun 22, 2025
kateinoigakukun
added a commit
to kateinoigakukun/wasi-libc
that referenced
this pull request
Jun 22, 2025
abrown
pushed a commit
that referenced
this pull request
Jun 25, 2025
Update @bjorn3/browser_wasi_shim to version 0.4.2. This release includes a limited polyfill for `poll_oneoff`, which is necessary for the `pthread_cond` test to pass in the browser. bjorn3/browser_wasi_shim#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pthread_condtest usesnanosleepwhich eventually callspoll_oneoffbut@bjorn3/browser_wasi_shimdoes not implement it. So we skip the test for now, but we will revisit it later once bjorn3/browser_wasi_shim#88 is merged.