Add debug trace for library #159
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a self hosted runner administrator i want so know why my runners are crashing. If this is related to k8s, a stack trace often does help to pin down the origin of the issue.
Therefore, this change does improve the debug capability of the k8s hook implementation by providing a stack trace via the debug output if an exception happend.
Before the change
After the change
Change summary
The primary change is to enable a correct
sourceMap
output for the code, so the stack trace will show up the.ts
origin with the correct line number of the trace and not some location within the minified / bakedindex.js
.packages/hooklib
and thepackages/k8s
andpackages/docker
was changed from a JS based include into a TypeScript composite build. To make this happen, thebaseUrl
&rootUrl
required adaptation.tsc
followed byncc
was replaced with a direct call ofncc
due to otherwise the line number reference got lost.k8s/package.json
that appear now due to the linkage is happening now on a typed based linkage. I guess there was also a bug within themainContainerContextPorts[port.containerPort]
assignment.ncc
andtypescript
library update was required due to the used version caused a bug.