feat(k8s): add /github/home to containerAction mounts and surface createSecretForEnvs errors #181 #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikola-jokic is there any way I could get you to take a look at this PR? I'm itching to delete our internal fork of this repo, and the custom actions-runner image I had to build to use the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi maintainers, this PR is meant to accomplish two things:
/github/homedirectory available from container actions, which is a path frequently relied on by actions creating files in a user's home ($HOME/.netrcfor instance)I ran into both issues during a k8s runner deployment and a similar concern was raised in #181. I'd prefer not to maintain my internal for and custom runner image just for this additional mount if I don't have to
Thanks for the consideration!