Skip to content

Commit eff380d

Browse files
HarithaVattikutiHarithaVattikuti
authored
Fix macos latest check failures (#1041)
* Update latest node versions * Update latest node versions * Update test data * Update test data * Update test data * Update test data * Update test data * macos lts failure fix * Update macos-13
1 parent c2ac33f commit eff380d

File tree

7 files changed

+27
-27
lines changed

7 files changed

+27
-27
lines changed

‎.github/workflows/e2e-cache.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
fail-fast: false
2020
matrix:
2121
os: [ubuntu-latest, windows-latest, macos-latest]
22-
node-version: [12, 14, 16]
22+
node-version: [18, 20, 22]
2323
steps:
2424
- uses: actions/checkout@v4
2525
- name: Clean global cache
@@ -42,7 +42,7 @@ jobs:
4242
fail-fast: false
4343
matrix:
4444
os: [ubuntu-latest, windows-latest, macos-latest]
45-
node-version: [12, 14, 16]
45+
node-version: [18, 20, 22]
4646
steps:
4747
- uses: actions/checkout@v4
4848
- name: Install pnpm
@@ -75,7 +75,7 @@ jobs:
7575
fail-fast: false
7676
matrix:
7777
os: [ubuntu-latest, windows-latest, macos-latest]
78-
node-version: [14, 16]
78+
node-version: [18, 20]
7979
steps:
8080
- uses: actions/checkout@v4
8181
- name: Yarn version
@@ -107,7 +107,7 @@ jobs:
107107
fail-fast: false
108108
matrix:
109109
os: [ubuntu-latest, windows-latest, macos-latest]
110-
node-version: [12, 14, 16]
110+
node-version: [18, 20, 22]
111111
steps:
112112
- uses: actions/checkout@v4
113113
- name: Update yarn
@@ -139,7 +139,7 @@ jobs:
139139
name: Test yarn subprojects
140140
strategy:
141141
matrix:
142-
node-version: [12, 14, 16]
142+
node-version: [18, 20, 22]
143143
runs-on: ubuntu-latest
144144

145145
steps:
@@ -166,7 +166,7 @@ jobs:
166166
name: Test yarn subprojects all locally managed
167167
strategy:
168168
matrix:
169-
node-version: [12, 14, 16]
169+
node-version: [18, 20, 22]
170170
runs-on: ubuntu-latest
171171

172172
steps:
@@ -193,7 +193,7 @@ jobs:
193193
name: Test yarn subprojects some locally managed
194194
strategy:
195195
matrix:
196-
node-version: [12, 14, 16]
196+
node-version: [18, 20, 22]
197197
runs-on: ubuntu-latest
198198

199199
steps:
@@ -220,7 +220,7 @@ jobs:
220220
name: Test yarn subprojects managed by git
221221
strategy:
222222
matrix:
223-
node-version: [12, 14, 16]
223+
node-version: [18, 20, 22]
224224
runs-on: ubuntu-latest
225225

226226
steps:

‎.github/workflows/versions.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
fail-fast: false
1919
matrix:
2020
os: [ubuntu-latest, windows-latest, macos-latest]
21-
node-version: [10, 12, 14]
21+
node-version: [18, 20, 22]
2222
steps:
2323
- uses: actions/checkout@v4
2424
- name: Setup Node
@@ -34,7 +34,7 @@ jobs:
3434
strategy:
3535
fail-fast: false
3636
matrix:
37-
os: [ubuntu-latest, windows-latest, macos-latest]
37+
os: [ubuntu-latest, windows-latest, macos-13]
3838
node-version: [lts/dubnium, lts/erbium, lts/fermium, lts/*, lts/-1]
3939
steps:
4040
- uses: actions/checkout@v4
@@ -43,7 +43,7 @@ jobs:
4343
with:
4444
node-version: ${{ matrix.node-version }}
4545
check-latest: true
46-
- if: runner.os != 'Windows'
46+
- if: runner.os != 'Windows' && runner.os != 'macOS'
4747
name: Verify node and npm
4848
run: |
4949
. "$NVM_DIR/nvm.sh"
@@ -83,7 +83,7 @@ jobs:
8383
matrix:
8484
os: [ubuntu-latest, windows-latest, macos-latest]
8585
node-version:
86-
[16.0.0-nightly20210420a0261d231c, 17-nightly, 18.0.0-nightly]
86+
[20.11.0-nightly202312211a0be537da, 21-nightly, 18.0.0-nightly]
8787
steps:
8888
- uses: actions/checkout@v4
8989
- name: Setup Node
@@ -103,7 +103,7 @@ jobs:
103103
fail-fast: false
104104
matrix:
105105
os: [ubuntu-latest, windows-latest, macos-latest]
106-
node-version: [16.0.0-rc.1, 18.0.0-rc.2, 19.0.0-rc.0]
106+
node-version: [20.0.0-rc.1, 18.0.0-rc.2, 19.0.0-rc.0]
107107
steps:
108108
- uses: actions/checkout@v4
109109
- name: Setup Node
@@ -123,7 +123,7 @@ jobs:
123123
fail-fast: false
124124
matrix:
125125
os: [ubuntu-latest, windows-latest, macos-latest]
126-
node-version: [10.15, 12.16.0, 14.2.0, 16.3.0]
126+
node-version: [18.20.0, 20.10.0, 22.0.0]
127127
steps:
128128
- uses: actions/checkout@v4
129129
- name: Setup Node
@@ -140,7 +140,7 @@ jobs:
140140
fail-fast: false
141141
matrix:
142142
os: [ubuntu-latest, windows-latest, macos-latest]
143-
node-version: [10, 12, 14]
143+
node-version: [18, 20, 22]
144144
steps:
145145
- uses: actions/checkout@v4
146146
- name: Setup Node and check latest
@@ -167,7 +167,7 @@ jobs:
167167
with:
168168
node-version-file: '__tests__/data/${{ matrix.node-version-file }}'
169169
- name: Verify node
170-
run: __tests__/verify-node.sh 14
170+
run: __tests__/verify-node.sh 20
171171

172172
version-file-volta:
173173
runs-on: ${{ matrix.os }}
@@ -182,7 +182,7 @@ jobs:
182182
with:
183183
node-version-file: '__tests__/data/package-volta.json'
184184
- name: Verify node
185-
run: __tests__/verify-node.sh 16
185+
run: __tests__/verify-node.sh 20
186186

187187
version-file-volta-extends:
188188
runs-on: ${{ matrix.os }}
@@ -197,15 +197,15 @@ jobs:
197197
with:
198198
node-version-file: '__tests__/data/package-volta-extends.json'
199199
- name: Verify node
200-
run: __tests__/verify-node.sh 16
200+
run: __tests__/verify-node.sh 20
201201

202202
node-dist:
203203
runs-on: ${{ matrix.os }}
204204
strategy:
205205
fail-fast: false
206206
matrix:
207207
os: [ubuntu-latest, windows-latest, macos-latest]
208-
node-version: [11, 13]
208+
node-version: [17, 19]
209209
steps:
210210
- uses: actions/checkout@v4
211211
- name: Setup Node from dist
@@ -221,7 +221,7 @@ jobs:
221221
strategy:
222222
fail-fast: false
223223
matrix:
224-
os: [ubuntu-latest, windows-latest, macos-latest]
224+
os: [ubuntu-latest, windows-latest, macos-13]
225225
steps:
226226
- uses: actions/checkout@v4
227227
# test old versions which didn't have npm and layout different
@@ -237,10 +237,10 @@ jobs:
237237
runs-on: windows-latest
238238
steps:
239239
- uses: actions/checkout@v4
240-
- name: Setup node 14 x86 from dist
240+
- name: Setup node 20 x86 from dist
241241
uses: ./
242242
with:
243-
node-version: '14'
243+
node-version: '20'
244244
architecture: 'x86'
245245
- name: Verify node
246246
run: __tests__/verify-arch.sh "ia32"

‎__tests__/data/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v14
1+
v20

‎__tests__/data/.tool-versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
nodejs 14.0.0
1+
nodejs 20.0.0

‎__tests__/data/.tool-versions-node

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
node 14.0.0
1+
node 20.0.0

‎__tests__/data/package-volta.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
"node": "^14.0.0"
44
},
55
"volta": {
6-
"node": "16.0.0"
6+
"node": "20.0.0"
77
}
88
}

‎__tests__/data/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"engines": {
3-
"node": "^14.0.0"
3+
"node": "^20.0.0"
44
}
55
}

0 commit comments

Comments
 (0)