tsc output format changed?

[NicholasBoll]

I noticed Typescript errors were no longer being matched correctly. After a bit of research it seems the format has changed? I couldn't find confirmation, but here's a comparison:

Before:

src/commandHandler.ts(107,11): error TS2322: Type 'Response<ReposGetCollaboratorPermissionLevelResponse>' is not assignable to type 'Response<CollaboratorPermissionLevel>'.

Now:

src/commandHandler.ts:107:11 - error TS2322: Type 'Response<ReposGetCollaboratorPermissionLevelResponse>' is not assignable to type 'Response<CollaboratorPermissionLevel>'.

It seems a small change to the regex in the tsc.json could be changed to accommodate both patterns.

[NicholasBoll]

Perhaps this is a detection of the environment? Locally I get the colon pattern. I think on the CI I get the paren pattern.

The output from the Github CI makes it a bit hard to compare (https://github.com/Workday/canvas-kit/pull/609/checks?check_run_id=636485860):

##[error]modules/tooltip/react/lib/Tooltip.tsx(46,3): error TS2322: Type '"label1"' is not assignable to type '"label" | "describe"'.

But the line number wasn't properly extracted:

[NicholasBoll]

I figured out why it wasn't able to find the correct line. The Regex matches a group of any of these patterns: (0) or (0,0) or (0,0,0). All of those are set to the location (which doesn't seem to be working) instead of line and column which does seem to be working.

That seems like a different issue?

[NicholasBoll]

I was able to override the matcher here and it worked to put annotations on the correct line: Workday/canvas-kit@c1e38be

[bryanmacfarlane]

I'll take a look at how you overrode and see if we can improve our matcher.

[ockham]

Seems like this has been fixed by #125 (available in actions/setup-node@2.1.5 and later)?

[bryanmacfarlane]

@NicholasBoll - can you confirm if latest (2.1.5) addresses the issue?

[NicholasBoll]

It looks like it works:

From https://github.com/Workday/canvas-kit/pull/994/files (commit with the annotation: Workday/canvas-kit@d5566f5)

[bryanmacfarlane]

@NicholasBoll Thanks for confirming!