Why hasn't version been removed?

[jsoref]

setup-node/action.yml

Lines 26 to 29 in 38d90ce

	# Deprecated option, do not use. Will not be supported after October 1, 2019
	version:
	description: 'Deprecated. Use node-version instead. Will not be supported after October 1, 2019'
	deprecationMessage: 'The version property will not be supported after October 1, 2019. Use node-version instead'

2019 was a long time ago...

[nickofthyme]

The deprecationMessage creates a lot of noice if used on many workflow jobs.

I'm happy to put up a PR to remove this if there is no ulterior reason for keeping it around. Thanks 🙏

[jsoref]

Your workflows should really be upgraded to not mention that property. I don't think that removing the field from the action.yml will improve your log entries.

That said, I'd be happy w/ someone else making the PR (I'm also willing, but I prefer to do work when there's some sign that the repository will accept my PR, and I have no evidence of this).

[nickofthyme]

Ugh yeah you are right, I forgot to remove passing the variable in a custom action. Thanks.

Exactly, if they would accept removal I'm happy to do it. TBD...

[jsoref]

That said, this Issue was given a tag last month by someone who has committed to this repository in the past month, so maybe it's a bit more alive than when I filed the issue. Wanna make the PR?

[nickofthyme]

True, yeah I can get to it in the next few weeks.

[dmitry-shibanov]

Hello everyone. The version input was removed in the v3 tag. For now I'm going to close the issue. If you have any concerns feel free to ping us.