cache-dependency-path with npm to a subfolder does not work

[kentlarsson]

Description:
cache-dependency-path to a subfolder results in Error: Some specified paths were not resolved, unable to cache dependencies.

Action version:

actions/setup-node@v3

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Tools version:

The node 16.x version with corresponding npm version you get in Github.

node-version: 16
check-latest: true

Repro steps:

Repo structure:

<git root>
├── docs
│   └── README.md
├── firebase.json
└── functions
    ├── jest.config.ts
    ├── lib
    ├── node_modules
    ├── package.json
    ├── package-lock.json
    ├── src
    ├── tsconfig.json
    └── tsconfig.prod.json

Relevant workflow part:

jobs:
  # This workflow contains a single job called "build"
  build:
    # The type of runner that the job will run on
    runs-on: ubuntu-latest

    # Steps represent a sequence of tasks that will be executed as part of the job
    steps:
      - name: setup node
        uses: actions/setup-node@v3
        with:
          node-version: 16
          check-latest: true
          cache: "npm"
          cache-dependency-path: "${ GITHUB_WORKSPACE }/functions/package-lock.json"

But for cache-dependency-path I've also tried these strings:

• "functions/package-lock.json"
• "./functions/package-lock.json"
• "*/package-lock.json"

And they all fail:

Environment details
/opt/hostedtoolcache/node/16.18.0/x64/bin/npm config get cache
/home/runner/.npm
Error: Some specified paths were not resolved, unable to cache dependencies.

Expected behavior:

Caching to work even though the package lock file is in a subfolder called functions.

Actual behavior:

See repro steps above.

[dsame]

Hello @kentlarsson, thanks for you input. We start to investigate the issue.

[kentlarsson]

Hello @kentlarsson, thanks for you input. We start to investigate the issue.

Thank you! Let me know if I can help out with any information. (I looked for some kind of verbose/debug flag for the action but didn't find one.)

[dsame]

Hello @kentlarsson, i tried to reproduce the problem but the following pipeline works as expected
https://github.com/akv-demo/setup-node-test/actions/runs/3477559354/workflow

This the build run the npm files are cached
https://github.com/akv-demo/setup-node-test/actions/runs/3477511902/jobs/5813760043#step:7:29

And here the cache it used
https://github.com/akv-demo/setup-node-test/actions/runs/3477559354/jobs/5813863202#step:3:73

Can you please double check you have package-lock.json commited in or fork the branch i created i try to reproduce the problem with it?

[kentlarsson]

Repo structure:

Hey! Thanks for investigating!

Yes it's committed, it's quite essential for us (but I know you have to ask of course).

I'll try to fork that repo and see if I can reproduce the issue. It might take a week though, but I'll do it and get back to you in this thread. Thanks again!

[dmitry-shibanov]

Hello @kentlarsson. Do you have any updates ?

[kentlarsson]

Sorry, I've had too much to do. But I just learned about ACTIONS_RUNNER_DEBUG which I guess you used? So I'll try to add that tomorrow to our repo and see what it says.

If I just fork your repo I guess we'd only make sure that the files are where they should. And since the ascii tree I had in my debug report was from the tree command I'd assume so (and package-lock we use all the time). I'll probably get more useful info the above way. Or did you have other reasons for suggesting a fork than to make sure package-lock.json and node_modules actually reside under functions/ ?

[dsame]

Hello @kentlarsson, to investigate and solve the problem we need to reproduce it. Currently i am not able to get the actual error despite i reproduced the repo according the description.

Can you please try to replace

  cache-dependency-path: "${ GITHUB_WORKSPACE }/functions/package-lock.json"

with

 cache-dependency-path: functions/package-lock.json

or

  cache-dependency-path: ${{github.workspace}}/functions/package-lock.json

as a quick fix that may help?

[kentlarsson]

Hey! Thanks for your attention! I'm sorry I answer a bit later then I say, it's been a very busy period at work. But I'll do my best to give the best info I can asap though. :-)

I tried both

cache-dependency-path: functions/package-lock.json

And

cache-dependency-path: ${{github.workspace}}/functions/package-lock.json

But I got the same result. I also enabled ACTIONS_STEP_DEBUG but I still see no more info then Error: Some specified paths were not resolved, unable to cache dependencies.

I'll try the fork now so that I've tried everything suggest. Will be back with those results.

[kentlarsson]

Also to quadruple check paths:

❯ git rev-parse --show-toplevel
/home/kent/xyz/backend/npm-cache-test

npm-cache-test on  npm-cache-test [$]
❯ pwd
/home/kent/xyz/backend/npm-cache-test

npm-cache-test on  npm-cache-test [$]
❯ ls -l functions/package*
.rw-r--r-- 1.8M kent 30 Nov 22:55 functions/package-lock.json
.rw-r--r-- 2.7k kent 30 Nov 22:31 functions/package.json

[kentlarsson]

I forked your repo now!

At first I just forked main, it was my first fork plus I am a bit sloppy. Anyway, I copy pasted over your workflow file with npm and I could reproduce the error.

• repo fork with your npm workflow in HEAD: https://github.com/kentlarsson/setup-node-test/actions
• logs when I turned on ACTIONS_RUNNER_DEBUG

I ran the CI action four times, from oldest to newest:

1. Green/Worked because it still had yarn in there.
2. Commit when I changed to your npm workflow
3. I ran it manually as well
4. I enabled ACTIONS_RUNNER_DEBUG to see if I could get more debug info (but I didn't see any)

Maybe the container is somehow different from what you expect?

Thanks again for helping me out!

[edimossilva]

Hey @kentlarsson I believe that I am having kind of the same issue in this pipeline, this is my config file.

Maybe I am missing something, but please let me know if you spot anything relevant