Log Node.js version using

[fishcharlie]

Couple of things.

First if you specify node-version of 10, does that use the absoute latest version of Node.js v10 (both minor and patch versions)?

Second, does node-version of 10.x use the latest version when taking account patch versions? Or does .x just mean the minor version?

Finally, it'd be great if this action printed the Node.js version it decided to use in the logs of GitHub Actions so developers can determine which Node.js version it decided to use, which would make debugging SO much easier.

[joshmgross]

👋 Hey @fishcharlie. Specifying a node-version of 10 and 10.x will have the same result. This follows semver, where 10 == 10.x == 10.x.x, which is effectively "the latest version of Node.js v10 taking into account both minor and patch versions.

Finally, it'd be great if this action printed the Node.js version it decided to use in the logs of GitHub Actions

Great idea! That should be a quick fix.

[bryanmacfarlane]

Yes, it should work with any semver version spec. As part of this issue, I'll make sure it's logged as well. I'll also update the readme / docs

[fishcharlie]

Any updates on this? cc/ @bryanmacfarlane @joshmgross

[joshmgross]

@bryanmacfarlane are you still planning on doing this? If not, I can pick this up.

[bryanmacfarlane]

@joshmgross - I'm fine with you picking this up. If you do, look at recent commits in setup-go where I did it. I think it should also output npm version.

[fishcharlie]

Outputting the npm version too would be amazing!!!

[demian85]

Can someone please explain why my node version is not 12 as specified?

Part of my config file is

jobs:
  primary:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        node-version: [12.x]

    steps:
      - uses: actions/checkout@v1

      - name: Cache node modules
        uses: actions/cache@v1.1.0
        with:
          path: ~/.npm
          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
          restore-keys: |
            ${{ runner.os }}-node-
      - name: Node ${{ matrix.node-version }}
        uses: actions/setup-node@v1.1.0
        with:
          node-version: ${{ matrix.node-version }}

      - name: Installing dependencies
        run: npm install

And logging the node version to the console results in node version: 10.20.1

I do not quite understand where is the problem.

[bryanmacfarlane]

@demian85 can you log a separate issue? I would also try setup-node@v1 to ensure you're getting latest along with bug fixes

Here's a workflow of mind doing @ 12.x and it leads to node 12. https://github.com/bryanmacfarlane/actions-playground/runs/570652210?check_suite_focus=true

[fishcharlie]

@joshmgross Would be more than happy to review and/or test a PR for this when you have it up! Thanks so much for helping with this.