Skip to content

Include cache hit in example #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Include cache hit in example #408

wants to merge 2 commits into from

Conversation

JJ
Copy link

@JJ JJ commented Jan 18, 2022

cache-hit is in fact not mentioned anywhere in the README file

Description:

Adds the use of cache-hit to the example.

Related issue:

It's so simple the PR is possibly the best issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

JJ added 2 commits January 18, 2022 10:42
`cache-hit` is in fact not mentioned anywhere in the README file
@dmitry-shibanov
Copy link
Contributor

Hello @JJ. Thank you for your pull request. The example won't work because the action caches global directory, but not node_modules.

@JJ
Copy link
Author

JJ commented Jan 18, 2022

Hello @JJ. Thank you for your pull request. The example won't work because the action caches global directory, but not node_modules.

That would explain a lot of things. But then what it does is to download the dependent modules?
Is it possible to salvage this PR by clarifying exactly what the cache does and where does the speedups will be enjoyed?

@dmitry-shibanov
Copy link
Contributor

Hello @JJ. Thank you for your answer. Actually we have an information about cache in the advanced section. The action caches global cache directory. For example we use the npm get config cache to get global cache directory for npm.

@dmitry-shibanov
Copy link
Contributor

Hello @JJ. For now I'm going to close the pull request. Feel free to contact us If you have any questions.

deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.8.2 to 1.9.0.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@actions/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants