Skip to content

docs(no-log-password): point out the opt-in nature of the rule #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025

Conversation

Silejonu
Copy link
Contributor

No description provided.

@shatakshiiii shatakshiiii enabled auto-merge (squash) May 26, 2025 05:45
@shatakshiiii shatakshiiii disabled auto-merge May 26, 2025 13:57
@shatakshiiii
Copy link
Contributor

Hey @Silejonu, there are some tests failures inside test/test_transformer.py. Once that is fixed, this PR will be good to go. Meanwhile I am moving this PR to draft. Let us know if you need any help fixing the test.

@shatakshiiii shatakshiiii marked this pull request as draft May 26, 2025 14:02
@Silejonu
Copy link
Contributor Author

Silejonu commented May 26, 2025

Hey @shatakshiiii , I may be misunderstanding the output of the failed jobs, but I believe the issue lies in the CI or at least some files that were not changed in my commit.

The error seems to be the following:

E           assert '---\n# Make ...t a comment\n' == '---\n# Make ...t a comment\n'
E             
E             Skipping 384 identical leading characters in diff, use -v to show
E             - over 160\n\
E             ?           -
E             + over 160\n
E                 # this is not a comment"
E               ...
E             
E             ...Full output truncated (31 lines hidden), use '-vv' to show

@ianw
Copy link
Contributor

ianw commented May 28, 2025

Hey @shatakshiiii , I may be misunderstanding the output of the failed jobs, but I believe the issue lies in the CI or at least some files that were not changed in my commit.

See #4615

@Silejonu Silejonu marked this pull request as ready for review June 12, 2025 06:26
@ssbarnea ssbarnea enabled auto-merge June 12, 2025 15:04
@ssbarnea ssbarnea added this pull request to the merge queue Jun 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 12, 2025
@ssbarnea ssbarnea added this pull request to the merge queue Jun 13, 2025
@ssbarnea ssbarnea removed this pull request from the merge queue due to a manual request Jun 13, 2025
@ssbarnea ssbarnea enabled auto-merge June 13, 2025 14:58
@ssbarnea ssbarnea added this pull request to the merge queue Jun 13, 2025
Merged via the queue into ansible:main with commit b31868b Jun 13, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or PR is related to the docs skip-changelog Can be missed from the changelog.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants