Replace byte array zeroing loop with Arrays.fill and specify charset in String construction #9458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.原代码使用 new String(bos.toByteArray()) 会使用平台默认的字符集进行解码，可能导致跨平台或环境不一致时出现乱码
RongtongJin
reviewed
Jun 10, 2025
| for (int i = 0; i < bytes.length; i++) { | ||
| bytes[i] = (byte) 0x00; | ||
| } | ||
| Arrays.fill(bytes, (byte) 0x00); // 替换为 Arrays.fill() |
There was a problem hiding this comment.
Chinese comments are not allowed
There was a problem hiding this comment.
I've made the suggested changes. Please take another look when you have time：）
|
It would be better to create an issue first and link it to the PR. Additionally, it is recommended to write the title in English and follow the specified format. |
Thanks for your guidance! |
cat-and-tomato
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9458 +/- ##
=============================================
- Coverage 48.11% 48.00% -0.11%
+ Complexity 12015 11989 -26
=============================================
Files 1308 1308
Lines 92253 92252 -1
Branches 11808 11807 -1
=============================================
- Hits 44385 44288 -97
- Misses 42373 42454 +81
- Partials 5495 5510 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9460
Brief Description
This PR improves code readability and portability by replacing manual byte array zeroing and by explicitly specifying a charset when converting bytes to string.
How Did You Test This Change?
These changes are refactorings that do not alter functionality. Existing unit tests continue to pass. Manual testing was also performed to ensure behavior remains consistent.