[ISSUE #9471] load kv store before service start in PopConsumerService #9472
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9472 +/- ##
=============================================
- Coverage 48.14% 47.97% -0.17%
+ Complexity 12022 11982 -40
=============================================
Files 1308 1308
Lines 92253 92257 +4
Branches 11808 11810 +2
=============================================
- Hits 44413 44260 -153
- Misses 42352 42487 +135
- Partials 5488 5510 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
requested changes
Jun 18, 2025
| @@ -883,6 +883,10 @@ public boolean recoverAndInitService() throws CloneNotSupportedException { | |||
| result = this.messageStore.load(); | |||
| } | |||
|
|
|||
| if (brokerConfig.isPopConsumerKVServiceInit()) { | |||
| result = result && popConsumerService.load(); | |||
There was a problem hiding this comment.
init method in BrokerController#startBasicService
There was a problem hiding this comment.
init method in BrokerController#initialize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9471
Brief Description
How Did You Test This Change?