feat(android): progressbar thickness #717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovegaoshi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
addresses #85 for android only.
This PR adds props for android to adjust progress bar thickness, roundness, and thumb size, because android's AppCompatSeekBar is very thin.
The progress bar thickness is done by setting all of
AppCompatSeekBar'sgetProgressDrawable's Layers (where for android 15, 0 is the background; 1 is unknown; 2 is the current progress) height to a given value.The roundness is done by wrapping all of these layers into a
com.facebook.drawee.drawable.RoundedCornersDrawablethen applying a radius.The thumb size is done by using a custom Drawable (ForwardDrawable wrapping the original getThumb() Drawable) to draw a circle with a given size at the original thumb's
getRect.Test Plan:
with prop
thickness={100}, it should look likewith prop
thickness={100}androundness={100}, it should look likewith prop
thickness={100}androundness={100}andthumbsize={100}, it should look likeabove tests were done with android 14+ devices.
tested iOS builds does NOT break with android only props.