Track and invalidate linked partials and typedocs in dev cache #2323
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -12,7 +12,7 @@ | |||
| "lint:check-frontmatter": "node ./scripts/check-frontmatter.mjs", | |||
| "lint:validation": "npm run build", | |||
| "build": "tsx ./scripts/build-docs.ts", | |||
| "dev": "tsx ./scripts/build-docs.ts --watch", | |||
| "dev": "tsx watch ./scripts/build-docs.ts --watch", | |||
There was a problem hiding this comment.
This seems weird that it would need both watch flags...
There was a problem hiding this comment.
The first watch is to tell tsx to reload and restart the whole script if any of the .ts files change (eg pulling in main having an updated script). The second --watch is to run the script in dev mode holding the markdown in memory and all that.
scripts/build-docs.ts
Outdated
| @@ -827,5 +881,7 @@ template: wide | |||
| await fs.rename(config.distTempPath, config.distFinalPath) | |||
| } | |||
|
|
|||
| if (abortSignal?.aborted) throw new Error('Build aborted') | |||
There was a problem hiding this comment.
This abortsignal thing seems crazy there are so many instances of it and it's so frequent. Is this really the best way?
There was a problem hiding this comment.
I've cleaned it up to just abortSignal?.throwIfAborted() but this is largely just how abort controllers work, just check it throughout execution and exit early if need be.
NWylynko
deleted the
nick/fix-dev-cache-invalidation-for-partials-typedoc
branch
What does this solve?
<Typedoc />or<Include />of a partial is used and editedWhat changed?
Checklist