feat(workshops): update required fields for enrollment creation #66718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurnerRiley
approved these changes
Jun 25, 2025
| @@ -83,6 +83,10 @@ export default class WorkshopEnroll extends React.Component { | |||
| signUpUrl: result.sign_up_url, | |||
| workshopUrl: result.workshop_url, | |||
| }); | |||
|
|
|||
| if (result.workshop_enrollment_status === SUBMISSION_STATUSES.SUCCESS) { | |||
There was a problem hiding this comment.
Ahhh thank you, this was bugging me too!
…equired params are enforced
…school_info and leave that for the school info validation itself
…rged param is confirmation_email but neither are sent anyway so removed
…g from render function
drizco
force-pushed
the
ryan/workshops/feat/update-required-fields-for-enrollment-creation
branch
from
3b6ee58 to
eab544c
Compare
drizco
deleted the
ryan/workshops/feat/update-required-fields-for-enrollment-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes unnecessary params from workshop enrollment creation endpoint. also using rails strong parameters. lays the groundwork for removing the enrollment form entirely. I also removed some school_info validation from the enrollment model since that should be handled already in school_info model instead. I also tweaked the
workshop_enrollcomponent even though it's going to be deleted soon to get rid of a react error that was bugging me. it was complaining that nothing was returned from the render function because instead we are navigating to a different page (so the renderSuccess function was returning undefined). moved the relevant code to the on submission complete handler instead.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: