Skip to content

[CI] Cleanup TestImageHistory #4355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[CI] Cleanup TestImageHistory #4355

merged 1 commit into from
Jun 25, 2025

Conversation

apostasie
Copy link
Contributor

This extract the hard-coded comparison part out of TestImageHistory.

The point is to facilitate changing / upgrading the image in the future.

@apostasie
Copy link
Contributor Author

apostasie commented Jun 23, 2025 •
edited
Loading

Unrelated failures are:

@apostasie apostasie changed the title Cleanup TestImageHistory [CI] Cleanup TestImageHistory Jun 23, 2025
@apostasie apostasie mentioned this pull request Jun 23, 2025
Closed
@AkihiroSuda
Copy link
Member

Needs rebase

@apostasie
Cleanup TestImageHistory
08b026a 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie force-pushed the 2025-06-image-history branch from 195cf08 to 08b026a Compare June 24, 2025 00:50
@apostasie
Copy link
Contributor Author

Rebased.
Pending CI.

@apostasie
Copy link
Contributor Author

apostasie commented Jun 24, 2025 •
edited
Loading

Unrelated failures:

@apostasie
Copy link
Contributor Author

Last failure:

@AkihiroSuda AkihiroSuda added this to the v2.1.3 milestone Jun 25, 2025
AkihiroSuda
AkihiroSuda approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 15b2cc3 into containerd:main Jun 25, 2025
170 of 178 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@apostasie @AkihiroSuda