Skip to content

feat(query): full support for decimal64 #18198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 25, 2025
Merged

feat(query): full support for decimal64 #18198

merged 12 commits into from
Jun 25, 2025

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jun 19, 2025 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Arrow and native both write decimal64 to decimal128 and convert it back when reading
  • Hash join supports decimal64
  • All aggregate functions support decimal64

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jun 19, 2025
@forsaken628 forsaken628 force-pushed the decimal-join branch 4 times, most recently from a9c7818 to a5aab86 Compare June 21, 2025 02:53
@forsaken628 forsaken628 force-pushed the decimal-join branch 2 times, most recently from 51ebaf1 to 282c195 Compare June 24, 2025 09:16
@forsaken628 forsaken628 added the ci-benchmark Benchmark: run all test label Jun 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-18198-5845897-1750767848

note: this image tag is only available for internal use.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@forsaken628 forsaken628 changed the title feat(query): decimal64 feat(query): full support for decimal64 Jun 25, 2025
@forsaken628 forsaken628 marked this pull request as ready for review June 25, 2025 06:52
@forsaken628 forsaken628 requested a review from sundy-li June 25, 2025 06:52
@sundy-li
Copy link
Member

does this pr solve #18241 ?

If it did, better to have tests to cover that issue.

@forsaken628 forsaken628 linked an issue Jun 25, 2025 that may be closed by this pull request
bug: databend_functions_scalar_decimal::cast::register_decimal_to_string panic #18241
Closed
@forsaken628 forsaken628 merged commit 4729125 into databendlabs:main Jun 25, 2025
244 of 249 checks passed
@forsaken628 forsaken628 deleted the decimal-join branch June 25, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: databend_functions_scalar_decimal::cast::register_decimal_to_string panic
2 participants
@forsaken628 @sundy-li