Skip to content

chore(cache): Add minimum threshold for table data disk cache size #18227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Jun 23, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Introduce TABLE_DATA_DISK_CACHE_SIZE_THRESHOLD (1024 bytes) to better handle disk cache enabling logic.

Any configuration value below this threshold will disable the table data disk cache.

This change temporarily addresses an issue with cloud platform deployment where setting the disk cache size to zero prevents the physical volume from being loaded.

Additional logging for on-disk cache configuration added to improve diagnostics.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Introduce TABLE_DATA_DISK_CACHE_SIZE_THRESHOLD (1024 bytes) to better handle disk
cache enabling logic.

Any configuration value below this threshold will disable the table data disk cache.

This change temporarily addresses an issue with cloud platform deployment where
setting the disk cache size to zero prevents the physical volume from being loaded.

Additional logging for on-disk cache configuration added to improve diagnostics.
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jun 23, 2025
Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825406277

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 18
Jobs with Retryable Errors 0
Jobs with Code/Test Issues 18

⛔️ Retry Status: CANCELLED

Reason: Higher priority request detected - retry has been cancelled to avoid resource conflicts.


🔍 Detailed Job Analysis

⛔️ linux / build (x86_64, X64)

Status: Cancelled by higher priority request
Reason: Cancelled by higher priority request


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

@dantengsky dantengsky marked this pull request as ready for review June 23, 2025 13:27
@dantengsky dantengsky requested review from BohuTANG and everpcpc June 23, 2025 13:27
Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825485630

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 4
Jobs with Retryable Errors 3
Jobs with Code/Test Issues 1

✅ Retry Status: AUTOMATIC RETRY INITIATED

3 job(s) have been automatically retried due to infrastructure issues detected in annotations:

  • Runner communication failures
  • Network timeouts
  • Resource exhaustion
  • Other transient infrastructure problems

📈 Monitor Progress: View in Actions


🔍 Detailed Job Analysis

linux / test_unit

Status: Not retryable (Code/Test Issue)
Reason: Code/test issue detected
Annotations: 1 found

🔄 linux / test_stateless_standalone

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found

🔄 linux / test_stateful_standalone

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found

🔄 linux / sqllogic / standalone_minio (query, http, native)

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825485630

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 1
Jobs with Retryable Errors 1
Jobs with Code/Test Issues 0

✅ Retry Status: AUTOMATIC RETRY INITIATED

1 job(s) have been automatically retried due to infrastructure issues detected in annotations:

  • Runner communication failures
  • Network timeouts
  • Resource exhaustion
  • Other transient infrastructure problems

📈 Monitor Progress: View in Actions


🔍 Detailed Job Analysis

🔄 linux / test_stateless_standalone

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

2 similar comments
Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825485630

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 1
Jobs with Retryable Errors 1
Jobs with Code/Test Issues 0

✅ Retry Status: AUTOMATIC RETRY INITIATED

1 job(s) have been automatically retried due to infrastructure issues detected in annotations:

  • Runner communication failures
  • Network timeouts
  • Resource exhaustion
  • Other transient infrastructure problems

📈 Monitor Progress: View in Actions


🔍 Detailed Job Analysis

🔄 linux / test_stateless_standalone

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

Copy link
Contributor

🤖 Smart Auto-retry Analysis

Workflow Run: 15825485630

The workflow run has been analyzed for retryable errors using job annotations.


📊 Analysis Summary

Metric Count
Total Failed/Cancelled Jobs 1
Jobs with Retryable Errors 1
Jobs with Code/Test Issues 0

✅ Retry Status: AUTOMATIC RETRY INITIATED

1 job(s) have been automatically retried due to infrastructure issues detected in annotations:

  • Runner communication failures
  • Network timeouts
  • Resource exhaustion
  • Other transient infrastructure problems

📈 Monitor Progress: View in Actions


🔍 Detailed Job Analysis

🔄 linux / test_stateless_standalone

Status:Retryable (Infrastructure Issue)
Reason: Infrastructure issue detected
Annotations: 1 found


🤖 About This Analysis

This is an automated analysis and retry triggered by the smart retry workflow using job annotations. The system analyzes failure patterns to distinguish between:

  • 🔄 Infrastructure Issues: Runner failures, network timeouts, resource exhaustion
  • ❌ Code/Test Issues: Compilation errors, test failures, logic problems

Only infrastructure issues are automatically retried to avoid wasting resources on code problems that need manual fixes.

@BohuTANG BohuTANG merged commit 71d389a into databendlabs:main Jun 24, 2025
358 of 369 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants