Skip to content

chore: avoid setting empty conf for Session #18236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

chore: avoid setting empty conf for Session #18236

merged 1 commit into from
Jun 25, 2025

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Jun 24, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@SkyFan2002 SkyFan2002 requested a review from sundy-li June 24, 2025 07:36
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jun 24, 2025
@sundy-li sundy-li merged commit a55a9e6 into databendlabs:main Jun 25, 2025
146 of 153 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@Chasen-Zhang Chasen-Zhang Chasen-Zhang approved these changes

@hantmac hantmac Awaiting requested review from hantmac

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SkyFan2002 @sundy-li @Chasen-Zhang